Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize sub-bound handling #469

Merged
merged 3 commits into from
Oct 27, 2022
Merged

Generalize sub-bound handling #469

merged 3 commits into from
Oct 27, 2022

Conversation

zptro
Copy link
Collaborator

@zptro zptro commented Sep 26, 2022

#459 generalized sub-region parameter handling. Now I found some places that I had overlooked. With this PR sub-region parameters will be fully flexible in agent model as well.

Also fixes zone interval for external demand.

@zptro zptro requested a review from johpiip September 26, 2022 05:55
johpiip
johpiip previously approved these changes Oct 14, 2022
Copy link
Contributor

@johpiip johpiip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested by running 2018 and it works! Results are identical to those before bugs. :) Thank you! I am merging this.

@johpiip johpiip merged commit fbd9b73 into olusanya Oct 27, 2022
@johpiip johpiip deleted the fix/sub-bounds branch October 27, 2022 07:08
johpiip added a commit that referenced this pull request Oct 27, 2022
Generalize sub-bound handling (#469)
johpiip added a commit that referenced this pull request Oct 28, 2022
Generalize sub-bound handling (#469)
@johpiip johpiip added this to the v4.1.2 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Congested transit assignment not converging in olusanya
2 participants